Greg and Pieter are Bitcoin long-time core devs, There's no conflict of interest when miners determine the level of trust on the code of the network. View entire discussion (77 comments) More posts from the Bitcoin community. k. Posted by 3 days ago. Never forget where we came from. Jun 13, · Port of bitcoin core bitcoin# Summary: 3ee3d04 Add extra LevelDB source to Makefile (MarcoFalke) leveldb: enable runtime-detected crc32 instructions (Cory Fields) cf44e4c Squashed 'src/leveldb/' changes from a31c8aaff0 (Pieter . Jun 25, · Pieter Levels, founder of Nomad List, recently joined in expressing concerns about the ICO market. With a huge amount of money having been dumped into the startup efforts of ICO companies, few if.
Pieter levels bitcoinUpdate to LevelDB by sipa · Pull Request # · bitcoin/bitcoin · GitHub
This PR, on the other hand, has much better test coverage, and many people looked at it already. Post merge ACK fd9a Skip to content. New issue. Jump to bottom. Conversation Commits 9 Checks 3 Files changed. Copy link Quote reply. The major changes are: Announcements from outbound and whitelisted peers are now always preferred over those from inbound peers. This used to be the case for the first request by delaying the first request from inbound peers , and a bias afters.
The 2s delay for requests from inbound peers still exists, but after that, if viable outbound peers remain for any given transaction, they will always be tried first. No more hard cap of in flight transactions per peer, as there is less need for it memory usage is linear in the number of announcements, but independent from the number in flight, and CPU usage isn't affected by it. Furthermore, if only one peer announces a transaction, and it has over in flight already, we still want to request it from them.
The cap is replaced with a rule that announcements from such overloaded peers get an additional 2s delay possibly combined with the existing 2s delays for inbound connections, and for txid peers when wtxid peers are available. The limit of tracked announcements is reduced to ; this was excessive. Overhaul transaction request logic Copy link.
Conflicts No conflicts as of last run. This was referenced Sep 21, Per-Peer Message Capture Member Author. DrahtBot mentioned this pull request Sep 22, MarcoFalke reviewed Sep 22, View changes.
Just a couple of minor style comments so far. Need to review the big commit "Change transaction request logic to use txrequest" but dropping some general comments now Edit: glanced over that commit, it's really in the weeds for me to say anything sensible without a lot more review time approach ACK at least.
DrahtBot mentioned this pull request Sep 25, Delete limitedmap as it is unused now. Report and verify expirations. Sign in to view. I'm going to leave further comment-only nits for a follow-up now. Hide details View details laanwj merged commit c2c4dba into bitcoin : master Oct 14, 5 checks passed.
This replaces bitcoin , rebased on bitcoin and with many small changes. Just a sanity check review focused on: Tree-SHA ea7bb59d9c9cfbddfe9c6cbedeaf38a0b5ec7f5f0dbf1ebb7ec25a31eaeff3bdaf92d4b0f0dd7. Remove redundant p2p lock tacking for tx download functional tests …. Dependency on GitHub Periodically make block-relay connections and sync headers This commit was signed with a verified signature. Sign up for free to join this conversation on GitHub.
Already have an account? Sign in to comment. Linked issues. Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch.
Applying suggestions on deleted lines is not supported. As a side-note, it could be worthy to document what is meaned here by "syntactic correctness" if it's consensus criticial.
Added comments in Can future upgradable public key define their own sigops rules without branching inside the if success branch? They can certainly define their own cost rules, as long as the cost is at least 50 vbytes per check.
I'm not sure what you mean by "without branching". If a future softforked new pubkey type comes with its own new ratio test, maybe the code structure isn't going to be adequate? Can we enforce this assign-once property with either some cpp magic or compiler option? I've no idea. I'm sure there are ways to solve these softforkability guarantees more generically by encapsulating modifiable properties in an object Concept ACK 0e2a5e4.
Skip to content. New issue. Jump to bottom. Conversation Commits 19 Checks 3 Files changed. Copy link Quote reply. Copy link. Member Author. The verification side of the BIP test vectors is also added. No corresponding CTxDestination is added for it, as that isn't needed until we want wallet integration.
The taproot validation flags are also enabled for mempool transactions, and standardness rules are added stack item size limit, no annexes. No activation or activation mechanism is defined for testnet or mainnet. The test data is large several MB so it's stored in the qa-assets repo. A fuzzer for said format is added as well, whose primary purpose is coverage-based minimization of those dumps. View changes. I was surprised to learn that this was a line PR.
This was referenced Sep 19, Introduce deploymentstatus External signer support - Wallet Box edition Make script interpreter independent from storage type CScript Define a versionbits-based activation for the new consensus rules on regtest.
Includes sighashing code and many tests by Johnson Lau. Includes a test by Matthew Zipkin. Includes several tests and improvements by Greg Sanders. Sign in to view. Going to leave this for a follow-up, as it's not directly related to Taproot testing. Partial review; more soon. AccessCoin prevout ; assert! IsSpent ;. Hide details View details laanwj merged commit 3caee16 into bitcoin : master Oct 15, 5 checks passed. See the list of commits [below] bitcoin comment.
The history of this PR can be found in bitcoin Follow-up extra comments on taproot code and tests MarcoFalke reviewed Oct 21, Concept ACK 0e2a5e4 left some questions in the test commits. Merge Follow-up extra comments on taproot code and tests ….
This user has not uploaded their public key yet. Tree-SHA ccea8efc7ef99a43cbf3b9cd3f9dde5fd97a07ee66f2bc78aef0bdc5c9cb66cabbbdd6ca3defd8ba0ecb Merge bitcoin : Follow-up extra comments on taproot code and tests …. Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment.
Linked issues. Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied.